Open
Conversation
getAgeReturns10YearsIf10ago getAgeHasToBePositive checkIfAgeIsLargerThen11 Updated Tests: getAgeReturns1DayIfYesterday getAgeReturns5MonthsIf5MonthsAgo
Included meine UserVsalidatorTest Lösungen Changed UserValidator.isValidUsername
Included meine UserVsalidatorTest Lösungen Changed UserValidator.isValidUsername
ideadapt
reviewed
Nov 17, 2021
| // TODO | ||
|
|
||
| UserValidator uv = mock(UserValidator.class); | ||
| doReturn(true).when(uv).doesUsernameExist(anyString()); |
Contributor
There was a problem hiding this comment.
InexistingUsername steht im Testnamen :)
Zudem ist die SUT ja der UserController nicht der UserValidator.
|
|
||
| String username = "2OnlyLetters"; | ||
|
|
||
| UserValidator uv = new FakeUserValidator(); |
Contributor
There was a problem hiding this comment.
Die SUT sollte nie ein Fake sein. Du möchtest ja die echte UserValidator Klasse testen.
| } | ||
| } | ||
|
|
||
| static class doesUsernameExist{ |
Contributor
There was a problem hiding this comment.
Alle Tests sollten die Methode UserValidator.doesUsernameExist aufrufen und dessen Ergebnis prüfen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Einfach mal alles mocken bei withValidInexitingUsername_addUserToDB__MOCKITO